Add InstallTool RPC method for PluginService #5218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With pipedv1's plugin architecture, we have to provide a way to install the tool used in the plugin.
I considered the following ways and propose the first way.
I propose the first way because we should consider multiple plugins that want to install the same tool/version at the same time.
In such a situation, we should prevent race conditions, and we can handle this with a
sync.Mutex
or something similar in the first way.Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No