Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requires for stages in case of multi plugins quicksync pattern #5239

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

In case of multi plugins for a single application, and the deployment of the application is triggered in quick sync strategy, we need to add requires for stages to ensure they run in order instead of all at one.

Which issue(s) this PR fixes:

Part of #4980
Follow PR #5231

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202
Copy link
Member Author

cc @Warashi We need this or all forward stages in quicksync triggered deployment will run at one 👀

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.95%. Comparing base (988949a) to head (ca5caf5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5239   +/-   ##
=======================================
  Coverage   23.94%   23.95%           
=======================================
  Files         437      437           
  Lines       46994    47003    +9     
=======================================
+ Hits        11255    11258    +3     
- Misses      34835    34841    +6     
  Partials      904      904           
Flag Coverage Δ
23.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@khanhtc1202 khanhtc1202 merged commit c4ca5c3 into master Sep 30, 2024
17 checks passed
@khanhtc1202 khanhtc1202 deleted the quick-sync-multi-plugin branch September 30, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants