Fix quickstart workflow not to run by matrix #5262
Merged
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
t-kikuc
changed the title
t-kikuc
previously approved these changes
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5262 +/- ##
=======================================
Coverage 24.10% 24.10%
=======================================
Files 441 441
Lines 47099 47099
=======================================
Hits 11352 11352
Misses 34844 34844
Partials 903 903 ☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Oct 8, 2024
Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
t-kikuc
added a commit
that referenced
this pull request
Oct 8, 2024
#5263 (#5265) * Fix panic in ECS driftdetection when a taskdef in livestates does not exist (#5240) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Upgrade aws-sdk-go-v2 (#5241) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * upgrade aws-sdk-go-v2 Signed-off-by: t-kikuc <[email protected]> * upgrade aws-sdk-go-v2/**/* Signed-off-by: t-kikuc <[email protected]> * fix compile errors caused by the breaking change Signed-off-by: t-kikuc <[email protected]> * fix a test due to added RestartPolicy Signed-off-by: t-kikuc <[email protected]> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <[email protected]> * fix go.sum by `make update/go-deps` Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Remove an unused field 'configFilePathInGitRepo' (#5248) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * remove unused field 'configFilePathInGitRepo' Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Support fetching a piped config from AWS SSM Parameter Store (#5249) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * add --aws-ssm-parameter Signed-off-by: t-kikuc <[email protected]> * add config-aws-ssm-parameter to piped Signed-off-by: t-kikuc <[email protected]> * update docs of runtime options Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Remove subnet ordering in head manifest (#5254) Signed-off-by: HoangNguyen689 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Update quickstart header note (#5255) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Update feature status (#5256) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Support directly designating a gitSSHKey instead of File for launcher (#5258) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * add --git-ssh-key-env Signed-off-by: t-kikuc <[email protected]> * update docs: add '--git-ssh-key-env' Signed-off-by: t-kikuc <[email protected]> * add '\n' at the end of ssh key Signed-off-by: t-kikuc <[email protected]> * Directly use data instead of env Signed-off-by: t-kikuc <[email protected]> * Clarify the flag description Signed-off-by: t-kikuc <[email protected]> * fix error message: 'and' -> 'or' Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Add workflow steps to build and publish quickstart manifests (#5260) Signed-off-by: pipecd-bot <[email protected]> * Update workflow not to run by matrix (#5262) Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Update RELEASE to v0.49.1 and update v0.49.x docs (#5263) * update RELEASE to v0.49.1 Signed-off-by: t-kikuc <[email protected]> * update docs of v0.49.x by `make release version=v0.49.1` Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: HoangNguyen689 <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Tetsuya Kikuchi <[email protected]> Co-authored-by: HoangNguyen689 <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move steps, which creates PR to update quickstarts, as another job.
Without this PR, the step runs multiple times using matrix runs.
Which issue(s) this PR fixes:
Follow PR #5260
Does this PR introduce a user-facing change?: