Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate What and Why in the PR template #5278

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Oct 11, 2024

What this PR does / why we need it:

  • as title
  • What for?
    • Easier to distinguish which sentences are WHAT / WHY
    • Force committers to write WHY

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <[email protected]>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍🏻

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.31%. Comparing base (4824dc2) to head (5ae61b6).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5278      +/-   ##
==========================================
+ Coverage   24.28%   24.31%   +0.03%     
==========================================
  Files         440      440              
  Lines       46754    46776      +22     
==========================================
+ Hits        11352    11374      +22     
  Misses      34499    34499              
  Partials      903      903              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc enabled auto-merge (squash) October 11, 2024 05:06
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the point 👍

@t-kikuc t-kikuc merged commit 1c516d2 into master Oct 11, 2024
18 checks passed
@t-kikuc t-kikuc deleted the improve-pr-template branch October 11, 2024 06:02
t-kikuc added a commit to t-kikuc/pipecd that referenced this pull request Oct 11, 2024
t-kikuc added a commit to t-kikuc/pipecd that referenced this pull request Oct 11, 2024
* Separate What and Why (pipe-cd#5278)

Signed-off-by: t-kikuc <[email protected]>

* Remove Cloud Providers related docs (pipe-cd#5279)

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants