Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot navigate to the edit page even after clicking "Edit this page". #5287

Closed
Reimei1213 opened this issue Oct 22, 2024 · 2 comments · Fixed by #5289
Closed

Cannot navigate to the edit page even after clicking "Edit this page". #5287

Reimei1213 opened this issue Oct 22, 2024 · 2 comments · Fixed by #5289
Labels
kind/bug Something isn't working

Comments

@Reimei1213
Copy link
Contributor

What happened:
Clicking “Edit this page” in the upper right corner takes me to an unintended page.

  • Extra slash between en and docs-v0.49.x in url
  • Missing .md extension

スクリーンショット 2024-10-22 23 27 47

What you expected to happen:

I wanted to transition to this page.

How to reproduce it:

https://pipecd.dev/docs-v0.49.x/user-guide/metrics/

Environment:

  • piped version:
  • control-plane version:
  • Others:
@Reimei1213 Reimei1213 added the kind/bug Something isn't working label Oct 22, 2024
@Reimei1213 Reimei1213 changed the title cannot navigate to the edit page even after clicking "Edit this page". Cannot navigate to the edit page even after clicking "Edit this page". Oct 22, 2024
@ntheanh201
Copy link
Contributor

IMO, this happened because of this commit: #5017
When I ran Hugo locally with version 0.92.1, this issue didn't happen.
When I ran Hugo locally with version 0.128.0, this issue happened.

@khanhtc1202
Copy link
Member

@ntheanh201 @Reimei1213 Thanks for noticing us.

Could you also check the "Edit this page" link on this page? ref: https://pipecd.dev/docs-v0.49.x/quickstart/

Looks like if the docs markdown file is _index.md under the path name, it could jump correctly. So, for whatever fix, please ensure it also works with this kind of link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants