[Wait] Implemented the core of executing Wait with WaitStageOptions #5456
+326
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5456 +/- ##
==========================================
- Coverage 26.15% 26.14% -0.02%
==========================================
Files 456 458 +2
Lines 49022 49154 +132
==========================================
+ Hits 12823 12852 +29
- Misses 35174 35280 +106
+ Partials 1025 1022 -3 ☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Dec 26, 2024
| "testing" | ||
| "time" | ||
|
|
||
| config "github.com/pipe-cd/pipecd/pkg/configv1" |
There was a problem hiding this comment.
This should not be here, isn't it?
There was a problem hiding this comment.
@khanhtc1202
Thanks, I fixed them: 2be9e5d
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
changed the title
Signed-off-by: t-kikuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
WaitStageOptionsexecute()of WaitTODO:
SkipOnoptionsWhy we need it:
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: