Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pisi parser is too tolerant of incorrect formatting. #1

Open
4fury-c3440d8 opened this issue Aug 21, 2020 · 1 comment
Open

pisi parser is too tolerant of incorrect formatting. #1

4fury-c3440d8 opened this issue Aug 21, 2020 · 1 comment

Comments

@4fury-c3440d8
Copy link

  • Create congruent formatting policy for build files.
  • Include in pisi's source code pspec.xml and actions.py file formatting checker tool that terminates build with critical error if any file is not indented(spaces or tabs) correctly.

Frequent issues:

  • spaces or tabs at the end of strings.
  • different characters (spaces or tabs) at the beginning of strings (also, in the same column).
  • redundant empty strings.
  • incomplete or missing comment at the beginning of file.
@safaariman
Copy link
Contributor

These are actually more about linting. I am not sure if this is a good approach to put code linting into Pisi. This is more like a CI issue. We probably check this with a CI tool at PR stage. We can also prevent people pushing these commits using pre-commit hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants