New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce type annotations #2974

Open

piskvorky opened this issue Oct 6, 2020 · 1 comment

Labels

difficulty medium wishlist

Owner

piskvorky commented Oct 6, 2020 •

edited

Loading

Following @mpenkov's effort for smart_open in piskvorky/smart_open#545, we could also introduce type annotations into Gensim.

The benefits are mild (nothing much gained), so this would be mostly for the documentation and CI.

Ticket only relevant once we drop py3.6, because without PEP 585 the annotations are too ugly and code-obfuscating, and PEP585 is py3.7+ only.

piskvorky added wishlist difficulty medium labels

Collaborator

mpenkov commented Oct 6, 2020

Check out https://github.com/mpenkov/kutuzov/ (and https://pypi.org/project/kutuzov/) - it's what I'm using to generate type annotations from docstrings automatically. It saves a bit of effort.

It's a fresh project though, so PRs welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment