Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CfService.getVolumes() is package private and not accessible outside of the io.pivotal.cfenv.core package. #286

Open
KaiHofstetter opened this issue Dec 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@KaiHofstetter
Copy link

Describe the bug

I'm trying the read the volumes as described in the README:

CfEnv cfEnv = new CfEnv();
List<CfVolume> cfVolumes = cfEnv.findServiceByName("nfs1").getVolumes();
String path = cfVolumes.get(0).getPath();

Unfortunately, the CfService.getVolumes() method is package private and is not accessible outside of the io.pivotal.cfenv.core package.

public class CfService {
...
	List<CfVolume> getVolumes() {
		return cfVolumes;
	}
...
}

(see CfService)

I assume this is a bug.

Furthermore, the cfVolumes.get(0).getPath(); returns a Path object and not a String, as shown in the README example.

I would be happy to provide a PR to fix this.

Reproduction steps

Try to compile the example in the README:

CfEnv cfEnv = new CfEnv();
List<CfVolume> cfVolumes = cfEnv.findServiceByName("nfs1").getVolumes();
String path = cfVolumes.get(0).getPath();

Expected behavior

CfService.getVolumes() is public:

public class CfService {
...
	public List<CfVolume> getVolumes() {
		return cfVolumes;
	}
...
}

Additional context

No response

@KaiHofstetter KaiHofstetter added the bug Something isn't working label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant