Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for read-only JDBC URI #72

Open
otheriault opened this issue Oct 19, 2019 · 1 comment
Open

Add support for read-only JDBC URI #72

otheriault opened this issue Oct 19, 2019 · 1 comment

Comments

@otheriault
Copy link

otheriault commented Oct 19, 2019

First off, I really like the simplicity of this new CfEnv project for parsing Cloud Foundry VCAP_SERVICES and injecting properties into spring-boot for auto-configuration. I think it has a lot of potential!

I have been trying to figure out an easy way to support an additional parameter in the credentials property of a given CfService. My specific use case is to support a read-only URI that could be used as a secondary data source, similar to what is mentioned here: https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#howto-two-datasources.

In the best case, the jdbc-url for the secondary datasource would be provided in the service-broker/user-provided-service directly. In the worse case, the jdbc-url would have to be generated by a JdbcUrlCreator from a series of credentials.read-* properties (url/uri, host, port, username, password...) in the service-broker/user-provided-service.

Since spring-framework has no pre-defined properties for this specific use case, I'm not sure this is something that should be explicitly covered by this library. However, at the same time I feel that this library could be more accommodating to custom service-broker(s)/user-provided-service(s) credentials properties. As such, I think it's worth exploring how to support this use case through some sort of extensibility mechanism.

I am looking forward to the feedback on this and am willing to become a contributor to this project.

@pivotal-david-osullivan
Copy link
Member

Hi @otheriault, revisiting this issue, is this still an active requirement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants