[Helm Chart] pixie helm chart doesn't support excluding fargate from daemonset

[xdays]

Is your feature request related to a problem? Please describe.

When deployed to EKS with fargate enabled, the vizier-pem pod is always in Pending state because it is scheduled to fargate node.

k get pod -A | grep Pending
monitoring                   prometheus-prometheus-node-exporter-s6s99                         0/1     Pending     0          28d
newrelic                     vizier-pem-wq9xq                                                  0/1     Pending     0          114m

Describe the solution you'd like

We enable deploying pixie-chart from newrelic-bundle chart, it will be great if pixie-chart can respect the value global.fargate from that chart.

Describe alternatives you've considered

I see pixie operator chart support patches, but I can't get it to work, it fails the validation.

Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(Vizier.spec.patches.spec): invalid type for dev.px.v1alpha1.Vizier.spec.patches: got "map", expected "string"

This is the patches value I used.

# one line version for helm
{"spec": {"template": {"spec": {"affinity": {"nodeAffinity": {"requiredDuringSchedulingIgnoredDuringExecution": {"nodeSelectorTerms": [ {"matchExpressions": [ {"key": "eks.amazonaws.com/compute-type", "operator": "NotIn", "values": [ "fargate" ]}]}]}}}}}}}

# prettified json
{
  "spec": {
    "template": {
      "spec": {
        "affinity": {
          "nodeAffinity": {
            "requiredDuringSchedulingIgnoredDuringExecution": {
              "nodeSelectorTerms": [
                {
                  "matchExpressions": [
                    {
                      "key": "eks.amazonaws.com/compute-type",
                      "operator": "NotIn",
                      "values": [
                        "fargate"
                      ]
                    }
                  ]
                }
              ]
            }
          }
        }
      }
    }
  }
}

Additional context
Add any other context or screenshots about the feature request here.

Related issues:

• [pixie-chart] - nodeSelector not working newrelic/helm-charts#945
• EKS Fargate Support #263

[cdenneen]

Has anyone got this to work? This chart needs to support affinity to be passed to it.

[philomory]

The "patches" argument needs to be passed like this:

patches:
  vizier-pem: '{"spec":{"template":{"spec":{"priorityClassName":"critical"}}}}'

... or similar, obviously you'd put your own patch there, I just used a smaller one for the sake of clarity.

In any case, the important point is, the key patches.<component-name> is used to hold the string representation of a "strategic merge patch" that will be applied to "component-name" (though, I'm not 100% sure which component-names, if any, are supported other than vizier-pem).