-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate amqp code generation and add test to catch drift #1827
base: main
Are you sure you want to change the base?
Automate amqp code generation and add test to catch drift #1827
Conversation
I think it's okay to skip linting for autogenerated files. Might be worth adding them to the exclusion list and calling this done. |
49f3a87
to
55b3e53
Compare
I think if you reduce the tab/spaces in the returns for There's a lot of them though, so unsure if it's worth the trouble. |
I was expecting the diff 'as is' to be pretty nasty, which is why I tried to keep the code formatting intact initially. I'll see how difficult it is to get the code generation to output relatively formatted code. |
@vihangm my latest approach gets the files formatted with minor whitespace differences. It required quite a few changes to the amqp code generation file. The changes to Let me know what you think. I'm holding off on fixing the |
Given that you have spent a bunch of time here, I trust your judgement. If you think running |
e1d37a4
to
db13912
Compare
Sounds good 👍. I've updated the branch based on the initial approach and it's ready for review now. |
7dc1bab
to
ada6662
Compare
Signed-off-by: Dom Del Nano <[email protected]> (cherry picked from commit 64b67a72291d4ca48c54b9c26b47c73fb8f25b5b)
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
ada6662
to
08d1604
Compare
Summary: Automate amqp code generation and add test to catch drift
This is a work in progress change to implement what was described here.
Relevant Issues: #1820 (comment)
Type of change: /kind cleanup
Test Plan:
diff_file
rules fail until linting issues are resolved