Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e test flakiness #9249

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix e2e test flakiness #9249

wants to merge 5 commits into from
+34 −14

Conversation

fungairino
Copy link
Collaborator

What does this PR do?

Discussion

  • Were there multiple approaches you were deciding between?

Demo

  • Paste a screenshot or demo video here

Future Work

  • Work for the issue/ticket that will be in a follow-up PR

Checklist

Leave all that are relevant and check off as completed

  • This PR requires a security review
  • This PR introduces a new library: double check it's MIT/Apache2/permissively licensed
  • This PR requires a node/npm version update: let the team know on #engineering
  • This PR requires a documentation change (link to old docs)
  • This PR requires a tutorial update (link to old tutorials)
  • This PR requires a feature flag
  • This PR requires a environment variable change
  • Added jest or playwright tests and/or storybook stories

For more information on our expectations for the PR process, see the
code review principles doc

@fungairino fungairino linked an issue Oct 7, 2024 that may be closed by this pull request
Fix flaky Playwright Tests #9193
Open
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

Playwright test results

passed  135 passed
flaky  3 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  142 tests across 46 suites
duration  12 minutes, 50 seconds
commit  4795c1e
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/runtime/customEvents.spec.ts › custom event brick functionality

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.03%. Comparing base (8318d74) to head (4795c1e).
Report is 345 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9249      +/-   ##
==========================================
+ Coverage   74.24%   75.03%   +0.78%     
==========================================
  Files        1332     1371      +39     
  Lines       40817    42374    +1557     
  Branches     7634     7922     +288     
==========================================
+ Hits        30306    31794    +1488     
- Misses      10511    10580      +69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fungairino fungairino

Labels
developer experience testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky Playwright Tests
2 participants
@fungairino @twschiller