You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, thanks for this project. Just wanted to share a potential issue:
I upgraded to [email protected] (to prep for 7 and offer canvas fallback support) and was getting errors out of the graphics-smooth lib when trying to build (this is a TS project):
node_modules/@pixi/graphics-smooth/index.d.ts:225:22 - error TS2415: Class 'SmoothGraphics' incorrectly extends base class 'Container<DisplayObject>'.
Property '_renderCanvas' is protected in type 'SmoothGraphics' but public in type 'Container<DisplayObject>'.
225 export declare class SmoothGraphics extends Container {
This is from @pixi/graphics-smooth/index.d.ts
I experimented with many different versions to come to the conclusion I think it's an actual issue. Changing _renderCanvas to public, or simply removing any access modifiers fixed this issue.
The text was updated successfully, but these errors were encountered:
yeah, we should fix it, canvas is "legacy" in only one meaning - it was in core, now its separated. We still need it at least for the tests against Skia.
Hey, thanks for this project. Just wanted to share a potential issue:
I upgraded to [email protected] (to prep for 7 and offer canvas fallback support) and was getting errors out of the graphics-smooth lib when trying to build (this is a TS project):
This is from
@pixi/graphics-smooth/index.d.ts
I experimented with many different versions to come to the conclusion I think it's an actual issue. Changing
_renderCanvas
to public, or simply removing any access modifiers fixed this issue.The text was updated successfully, but these errors were encountered: