Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable reload Notice #2

Open
jmilldotdev opened this issue Oct 2, 2021 · 4 comments
Open

Add setting to disable reload Notice #2

jmilldotdev opened this issue Oct 2, 2021 · 4 comments

Comments

@jmilldotdev
Copy link

Hello,

It would be nice if this plugin exposed a setting which allowed you to disable the Notice that is sent on reload. This notice covers the right drawer and makes development on plugins with ItemView a bit painful.

@pjeby
Copy link
Owner

pjeby commented Oct 2, 2021

I'm confused. On my machine the notice disappears quickly, often before I've even switched back to the window where Obsidian is running. It was added to provide a visual indicator that the reload occurred, without needing to check the debug console.

So I'm confused about how this relates to ItemView or the right drawer, especially since you can also just click the notice to make it go away.

Are you developing on mobile perhaps? Is it different than on the desktop in this respect?

@jmilldotdev
Copy link
Author

No, I'm developing on Desktop

image

image

The notice covers the icons in the top of the right drawer, and takes a couple of seconds or a second click to make it go away. All I'm suggesting is that it would be nice if there were a settings tab for the plugin with a toggle to display or not display the message which defaults to true.

No change in functionality and a user can disable it if they find it fits their workflow, like I did while I was working on this project

@pjeby
Copy link
Owner

pjeby commented Oct 2, 2021

If you drag the view in question downward in the drawer, it'll create a new split, and the notice won't overlay it. I'll consider the setting, but it's unlikely to be implemented soon. An alternative workaround would be to just comment out the Notice line in your installed version's main.js.

@jmilldotdev
Copy link
Author

Yeah, this is obviously a non-urgent suggestion. Your fix there is what I ended up doing, and I actually added the setting myself. I can PR it in if you're open to the suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants