You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As suggested in the README, I tried overriding isDesktopOnly and running the plugin on iOS, but it fails to load because of this line, since window.process is undefined on mobile:
With this change, hot reloading works for me on macOS, iOS, and iPadOS. I'd contribute it as a PR, but I'm not 100% confident about the logic and do not have Linux / Android devices to test on.
I'm also seeing an error in the mobile console, though it doesn't seem to actually interfere with hot reloading:
Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'this.app.vault.adapter.watchers.hasOwnProperty')
The error itself is trivially solved by checking if watchers is defined, but again, I'm not confident enough in the fix, so I thought I'd raise the issue for now.
The text was updated successfully, but these errors were encountered:
Man I really need to get this project on Typescript and a proper build. Ah well, thanks for the report, I've just put in fixes for 0.1.14, though I went a bit more conservative with the process stuff and kept it to "not windows or MacOS" for now. Please let me know if there are any console errors with the new version and I will tune up accordingly. Thanks!
As suggested in the README, I tried overriding
isDesktopOnly
and running the plugin on iOS, but it fails to load because of this line, sincewindow.process
is undefined on mobile:Based on your comment, I tried updating this to instead use Obsidian's
Platform
to check more directly for Linux and Android:With this change, hot reloading works for me on macOS, iOS, and iPadOS. I'd contribute it as a PR, but I'm not 100% confident about the logic and do not have Linux / Android devices to test on.
I'm also seeing an error in the mobile console, though it doesn't seem to actually interfere with hot reloading:
The error itself is trivially solved by checking if
watchers
is defined, but again, I'm not confident enough in the fix, so I thought I'd raise the issue for now.The text was updated successfully, but these errors were encountered: