Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t static link sqlite #8

Open
mxcl opened this issue Jan 11, 2025 · 4 comments
Open

Don’t static link sqlite #8

mxcl opened this issue Jan 11, 2025 · 4 comments

Comments

@mxcl
Copy link
Member

mxcl commented Jan 11, 2025

We can depend on the brew sqlite so we should avoid static linking (on Linux) and do that. This requires making sqlite static linking a feature flag or something on pkgx^2

@jhheider
Copy link
Contributor

this suggests that the default when not using a bundled* option is to dynamically link: https://lib.rs/crates/rusqlite

@jhheider
Copy link
Contributor

so, changing:

[target.'cfg(not(target_os = "macos"))'.dependencies]
rusqlite = { version = "0.32.1", features = ["bundled"] }

to:

[target.'cfg(pkgx_static)'.dependencies]
rusqlite = { version = "0.32.1", features = ["bundled"] }

and using cargo ... --cfg pkgx_static ... (iirc) should do it?

@mxcl
Copy link
Member Author

mxcl commented Jan 15, 2025

indeed

@mxcl
Copy link
Member Author

mxcl commented Jan 15, 2025

to be clear: for the normal pkgx builds we do I want it to be static, it's only for this tap I want it dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants