From d8bdeb526ab733f773fe1e2b62abe290addf5310 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A9ter=20Kir=C3=A1ly?= <pkiraly@gwdg.de>
Date: Thu, 7 Dec 2023 17:46:32 +0100
Subject: [PATCH] Implement code quality suggestions #323

---
 .../metadataqa/marc/cli/BLClassificationAnalysis.java  |  1 -
 .../marc/dao/record/Marc21BibliographicRecord.java     | 10 ++++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/main/java/de/gwdg/metadataqa/marc/cli/BLClassificationAnalysis.java b/src/main/java/de/gwdg/metadataqa/marc/cli/BLClassificationAnalysis.java
index e7c005abf..e112a9283 100644
--- a/src/main/java/de/gwdg/metadataqa/marc/cli/BLClassificationAnalysis.java
+++ b/src/main/java/de/gwdg/metadataqa/marc/cli/BLClassificationAnalysis.java
@@ -14,7 +14,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.Serializable;
-import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
 import java.util.List;
diff --git a/src/main/java/de/gwdg/metadataqa/marc/dao/record/Marc21BibliographicRecord.java b/src/main/java/de/gwdg/metadataqa/marc/dao/record/Marc21BibliographicRecord.java
index 1d860f4c0..7c7259048 100644
--- a/src/main/java/de/gwdg/metadataqa/marc/dao/record/Marc21BibliographicRecord.java
+++ b/src/main/java/de/gwdg/metadataqa/marc/dao/record/Marc21BibliographicRecord.java
@@ -36,10 +36,12 @@ public Marc21BibliographicRecord(String id) {
     super(id);
   }
 
+  @Override
   public Control008 getControl008() {
     return (Control008) this.control008;
   }
 
+  @Override
   public void setControl008(MarcPositionalControlField control008) {
     this.control008 = control008;
     control008.setMarcRecord(this);
@@ -47,6 +49,7 @@ public void setControl008(MarcPositionalControlField control008) {
   }
 
 
+  @Override
   public List<DataField> getAuthorityFields() {
     if (authorityTags == null) {
       initializeAuthorityTags();
@@ -54,6 +57,7 @@ public List<DataField> getAuthorityFields() {
     return getAuthorityFields(authorityTags);
   }
 
+  @Override
   public Map<DataField, AuthorityCategory> getAuthorityFieldsMap() {
     if (authorityTags == null) {
       initializeAuthorityTags();
@@ -61,6 +65,7 @@ public Map<DataField, AuthorityCategory> getAuthorityFieldsMap() {
     return getAuthorityFields(authorityTagsMap);
   }
 
+  @Override
   public boolean isAuthorityTag(String tag) {
     if (authorityTagsIndex == null) {
       initializeAuthorityTags();
@@ -68,6 +73,7 @@ public boolean isAuthorityTag(String tag) {
     return authorityTagsIndex.getOrDefault(tag, false);
   }
 
+  @Override
   public boolean isSkippableAuthoritySubfield(String tag, String code) {
     if (authorityTagsIndex == null)
       initializeAuthorityTags();
@@ -78,6 +84,7 @@ public boolean isSkippableAuthoritySubfield(String tag, String code) {
     return skippableAuthoritySubfields.get(tag).getOrDefault(tag, false);
   }
 
+  @Override
   public boolean isSubjectTag(String tag) {
     if (subjectTagIndex == null) {
       initializeAuthorityTags();
@@ -85,6 +92,7 @@ public boolean isSubjectTag(String tag) {
     return subjectTagIndex.getOrDefault(tag, false);
   }
 
+  @Override
   public boolean isSkippableSubjectSubfield(String tag, String code) {
     if (subjectTagIndex == null)
       initializeAuthorityTags();
@@ -122,6 +130,7 @@ private void initializeAuthorityTags() {
     authorityTagsMap.put(AuthorityCategory.OTHER, List.of("720", "753", "754"));
   }
 
+  @Override
   public Map<ThompsonTraillFields, List<String>> getThompsonTraillTagsMap() {
     if (thompsonTraillTagMap == null)
       initializeThompsonTraillTags();
@@ -152,6 +161,7 @@ private void initializeThompsonTraillTags() {
     thompsonTraillTagMap.put(ThompsonTraillFields.COUNTRY_OF_PUBLICATION, Arrays.asList("008/15"));
   }
 
+  @Override
   public Map<ShelfReadyFieldsBooks, Map<String, List<String>>> getShelfReadyMap() {
     if (shelfReadyMap == null)
       initializeShelfReadyMap();