Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorialMasthead page not loading with Uncaught TypeError (userGroup) #10751

Closed
kaitlinnewson opened this issue Dec 23, 2024 · 3 comments
Closed
Assignees
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Milestone

Comments

@kaitlinnewson
Copy link
Member

kaitlinnewson commented Dec 23, 2024

Describe the bug
The Editorial Masthead page is not loading due to a fatal error from the userGroup class - "Uncaught TypeError: PKP\userGroup\Repository::getMastheadUserIdsByRoleIds()"

To Reproduce
Steps to reproduce the behavior:

  1. On a journal home page, open the Editorial Masthead page from the main navigation
  2. See error

Expected Behaviour
When the editorial masthead link is clicked, it should open the editorial masthead page, which contains information about past editors and peer reviewers.

What application are you using?
OJS, OMP or OPS version main

Additional information

[Mon Dec 23 13:50:27 2024] [::1]:57777 [500]: GET /index.php/publicknowledge/en/about/editorialMasthead - Uncaught TypeError: PKP\userGroup\Repository::getMastheadUserIdsByRoleIds(): Argument #1 ($mastheadRoles) must be of type array, Illuminate\Database\Eloquent\Collection given, called in /Users/kaitlinnewson/Code/ojs-main/lib/pkp/pages/about/AboutContextHandler.php on line 97 and defined in /Users/kaitlinnewson/Code/ojs-main/lib/pkp/classes/userGroup/Repository.php:572
Stack trace:
#0 /Users/kaitlinnewson/Code/ojs-main/lib/pkp/pages/about/AboutContextHandler.php(97): PKP\userGroup\Repository->getMastheadUserIdsByRoleIds(Object(Illuminate\Database\Eloquent\Collection), 1)
#1 [internal function]: PKP\pages\about\AboutContextHandler->editorialMasthead(Array, Object(APP\core\Request))
#2 /Users/kaitlinnewson/Code/ojs-main/lib/pkp/classes/core/PKPRouter.php(329): call_user_func(Array, Array, Object(APP\core\Request))
#3 /Users/kaitlinnewson/Code/ojs-main/lib/pkp/classes/core/PKPPageRouter.php(253): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(APP\core\Request), Array, false)
#4 /Users/kaitlinnewson/Code/ojs-main/lib/pkp/classes/core/Dispatcher.php(158): PKP\core\PKPPageRouter->route(Object(APP\core\Request))
#5 /Users/kaitlinnewson/Code/ojs-main/lib/pkp/classes/core/PKPApplication.php(395): PKP\core\Dispatcher->dispatch(Object(APP\core\Request))
#6 /Users/kaitlinnewson/Code/ojs-main/index.php(30): PKP\core\PKPApplication->execute()
#7 {main}
  thrown in /Users/kaitlinnewson/Code/ojs-main/lib/pkp/classes/userGroup/Repository.php on line 572

PRs
pkp-lib --> #10754
ojs --> pkp/ojs#4571 [TEST ONLY]
omp --> pkp/omp#1798 [TEST ONLY]
ops --> pkp/ops#835 [TEST ONLY]

@kaitlinnewson kaitlinnewson added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Dec 23, 2024
@Tribunal33
Copy link

@kaitlinnewson What is the expected outcome?

@touhidurabir
Copy link
Member

touhidurabir commented Dec 28, 2024

@Vitaliy-1 or @bozana can one of you please review the PR at #10751 (comment) . It seems like a regression introduced by #10506 .

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 3, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 3, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 3, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 3, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 3, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 3, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 3, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 3, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 6, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 6, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 6, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 6, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 6, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 6, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 6, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/omp that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/ops that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/omp that referenced this issue Jan 7, 2025
touhidurabir added a commit to touhidurabir/ops that referenced this issue Jan 7, 2025
bozana added a commit that referenced this issue Jan 8, 2025
#10751 EditorialMasthead page issue with eloquent based user group update
@bozana bozana closed this as completed Jan 8, 2025
@bozana
Copy link
Collaborator

bozana commented Jan 8, 2025

I have merged the PKP-LIB and will update the submodule within my next PR merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Projects
None yet
Development

No branches or pull requests

4 participants