Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-static method PKPApplication::getRequest() cannot be called statically #32

Closed
hktang opened this issue Jul 28, 2022 · 3 comments
Closed

Comments

@hktang
Copy link

hktang commented Jul 28, 2022

Hello, I noticed the plagiarism plugin is preventing submission on PHP8. It should be the same issue as pkp/customHeader@0839e1d. I wonder if this is fixed in a new version?

Uncaught Error: Non-static method PKPApplication::getRequest() cannot be called statically in 
/var/www/ojs/plugins/generic/plagiarism/PlagiarismPlugin.inc.php:65

Thanks in advance for fixing this.

@asmecher
Copy link
Member

@hktang, what version of OJS are you using, and what version of the plagiarism plugin? (Please include this information with bug reports.)

@hktang
Copy link
Author

hktang commented Jul 29, 2022

Hi, I'm using the latest stable-3_3_0 branch of OJS.

The plagiarism plugin is at 1.0.5.1 according to the version.xml file.

Hope this helps. And thanks for the reminder about including version numbers.

asmecher added a commit that referenced this issue Jul 29, 2022
@asmecher
Copy link
Member

Thanks, @hktang -- the fix is trivial; you can apply 7c3986c. We'll include this in the next release.

@asmecher asmecher added this to the v1.0.6-0 for OJS 3.3.0-x milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants