Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendErrorMessage use wrong field to create notification #58

Closed
phulamnguyen opened this issue Mar 1, 2024 · 4 comments
Closed

sendErrorMessage use wrong field to create notification #58

phulamnguyen opened this issue Mar 1, 2024 · 4 comments

Comments

@phulamnguyen
Copy link

function createTrivialNotification($userId, ...) { .. } has the first params is $userId. But in the function sendErrorMessage, it uses table userGroup and passes group id to the param userId of function createTrivialNotification. So when sendErrorMessage is called, it makes an error insert notification because of foreign key constraints.
Please fix it soon.

@touhidurabir
Copy link
Member

@phulamnguyen which version of plugin are you using ? and also for which version of OJS/OMP ? I can see that in the current latest release at https://github.com/pkp/plagiarism/releases , it has been fixed .

@phulamnguyen
Copy link
Author

my ojs version is 3.4.0.5, the first installed version is 3.4, I just upgraded to version 3.4.0.5 a few days ago, and I see the structure of table notification is using user_id instead of user group id.

@touhidurabir
Copy link
Member

We haven't released any version for 3.4.0+ yet . I understand where the problem is arising . Currently we are working to update the ithenticate api (see #52) to the latest version and once that is done, we will release for 3.4.0+ . in the mean time if you need to use it with 3.4.0+, you need to checkout from the latest main branch to make it work.

@touhidurabir
Copy link
Member

Not planned yet . see #58 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants