Skip to content

Commit 04cbfdd

Browse files
pkp/pkp-lib#10674 Fix Complete submission editorial status for OPS
1 parent 13d565f commit 04cbfdd

File tree

1 file changed

+29
-25
lines changed

1 file changed

+29
-25
lines changed

src/pages/dashboard/composables/useDashboardConfigEditorialActivity.js

+29-25
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,22 @@ export function useDashboardConfigEditorialActivity() {
3636
},
3737
];
3838
}
39-
if (activeStage.id === pkp.const.WORKFLOW_STAGE_ID_SUBMISSION) {
40-
if (submission.submissionProgress) {
41-
return [
42-
{
43-
component: 'DashboardCellSubmissionActivityActionAlert',
44-
props: {
45-
actionName: 'openSubmissionWizard',
46-
actionLabel: t('submission.list.completeSubmission'),
47-
actionArgs: {submissionId: submission.id},
48-
},
39+
40+
// Not checking for submission stage, as OPS does not have it
41+
if (submission.submissionProgress) {
42+
return [
43+
{
44+
component: 'DashboardCellSubmissionActivityActionAlert',
45+
props: {
46+
actionName: 'openSubmissionWizard',
47+
actionLabel: t('submission.list.completeSubmission'),
48+
actionArgs: {submissionId: submission.id},
4949
},
50-
];
51-
}
50+
},
51+
];
52+
}
53+
54+
if (activeStage.id === pkp.const.WORKFLOW_STAGE_ID_SUBMISSION) {
5255
if (!submission.editorAssigned) {
5356
return [
5457
{
@@ -315,20 +318,21 @@ export function useDashboardConfigEditorialActivity() {
315318
function getEditorialActivityForMySubmissions(submission) {
316319
const activeStage = getActiveStage(submission);
317320

318-
if (activeStage.id === pkp.const.WORKFLOW_STAGE_ID_SUBMISSION) {
319-
if (submission.submissionProgress) {
320-
return [
321-
{
322-
component: 'DashboardCellSubmissionActivityActionAlert',
323-
props: {
324-
actionName: 'openSubmissionWizard',
325-
actionLabel: t('submission.list.completeSubmission'),
326-
actionArgs: {submissionId: submission.id},
327-
},
321+
// Not checking for submission stage, as OPS does not have it
322+
if (submission.submissionProgress) {
323+
return [
324+
{
325+
component: 'DashboardCellSubmissionActivityActionAlert',
326+
props: {
327+
actionName: 'openSubmissionWizard',
328+
actionLabel: t('submission.list.completeSubmission'),
329+
actionArgs: {submissionId: submission.id},
328330
},
329-
];
330-
}
331-
} else if (
331+
},
332+
];
333+
}
334+
335+
if (
332336
activeStage.id === pkp.const.WORKFLOW_STAGE_ID_EXTERNAL_REVIEW ||
333337
activeStage.id === pkp.const.WORKFLOW_STAGE_ID_INTERNAL_REVIEW
334338
) {

0 commit comments

Comments
 (0)