Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails when using 10-bit depth #4

Open
dbermond opened this issue Jul 27, 2018 · 3 comments
Open

Build fails when using 10-bit depth #4

dbermond opened this issue Jul 27, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dbermond
Copy link
Contributor

I'm getting the following compile error when trying to build in 10-bit mode:

/storage/linux/abs/davs2-git/src/davs2-git/source/common/decoder.cc: In function ‘void davs2_write_a_frame(davs2_picture_t*, davs2_frame_t*)’:
/storage/linux/abs/davs2-git/src/davs2-git/source/common/decoder.cc:959:42: error: cannot convert ‘pel_t* {aka short unsigned int*}’ to ‘uint8_t* {aka unsigned char*}’ in assignment
         pic->planes[0]  = frame->planes[0];
                                          ^
/storage/linux/abs/davs2-git/src/davs2-git/source/common/decoder.cc:960:42: error: cannot convert ‘pel_t* {aka short unsigned int*}’ to ‘uint8_t* {aka unsigned char*}’ in assignment
         pic->planes[1]  = frame->planes[1];
                                          ^
/storage/linux/abs/davs2-git/src/davs2-git/source/common/decoder.cc:961:42: error: cannot convert ‘pel_t* {aka short unsigned int*}’ to ‘uint8_t* {aka unsigned char*}’ in assignment
         pic->planes[2]  = frame->planes[2];
                                          ^
/storage/linux/abs/davs2-git/src/davs2-git/source/common/decoder.cc: In function ‘davs2_t* decoder_open(davs2_mgr_t*, davs2_t*, int)’:
/storage/linux/abs/davs2-git/src/davs2-git/source/common/decoder.cc:1071:73: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘davs2_t*’ [-Wformat=]
     sprintf(h->module_log.module_name, "Dec[%2d] %06llx", idx_decoder, h);
                                                                         ^
make: *** [Makefile:228: common/decoder.o] Error 1

Commands used:

$ ./configure 
        --prefix='/usr' \
        --enable-shared \
        --bit-depth='10' \
        --chroma-format='all' \
        --enable-lto \
        --enable-pic \
        --disable-swscale \
        --disable-lavf \
        --disable-ffms \
        --disable-gpac
$ make -j1

It builds fine with 8-bit depth by using --bit-depth='8'.

System Information:
OS: Arch Linux x86_64
Compiler: using gcc 7.3.1 to compile this (gcc 8.1.1 gives error)
yasm: 1.3.0
l-smash: 2.14.5
davs2: git master

@luofalei luofalei added enhancement New feature or request good first issue Good for newcomers labels Jul 28, 2018
@yuan-wenhua
Copy link

I met similar problem. When I do config:
./configure --enable-shared --bit-depth=10
The result is :BitDepth 10 not supported currently.

So, when will BitDepth 10 be supported?

@hybase
Copy link

hybase commented Jan 9, 2019

in 2019, 10-bit will be supported or not?

@perfectsun1990
Copy link

we expect support 10 bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants