-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle process death/re-creation on Android properly #151
Comments
Hi @RyanNewsom We agree that this is important functionality and are currently working on building it so it should be available in a future release. |
Thanks for the reply @zsweigart. Here is how you can save/restore a WebView in Android. |
@zsweigart are you guys working on this? I had an old co worker at a different company reach out to see if I found a resolution to this because they are seeing the same problem. Only option would be to fork your sdk and patch it ourselves. Thanks |
Hi Ryan, apologies for the staleness of the issue, OAuth has specifically been resolved in |
Hi Ryan, apologies, our QA ran through 3.5.0 with the DNKA flag off, and thus it looked like the issue was resolved, when in reality it was not. Unfortunately the helpful suggestion you gave earlier about saving WebView state doesn't quite work with our implementation, as the Bundle the WebView state provides is not actually sufficient to restore the correct state of the Link Flow. We are working on a fully native flow where process death will be handled correctly. |
Thanks for the update @amytang0 |
If you would like to opt-in to the fully native experience, please upgrade to the latest version 3.6.1 and email your client_id to [email protected] |
@amytang0 how stable is the fully native experience? |
I think this is still happening in React Native usage of the Plaid SDK. When the app is backgrounded with the Plaid SDK showing, it will kill the react-native MainActivity and then be forced to restart the app from scratch. |
@djMax this has not been resolved, hence the open state. The recommended solution is to switch to their native sdk which (hopefully) has this resolved |
The problem
Android may kill activities when users background an app if the phone is currently resource constrained. To the user though, they simply backgrounded the app, and when they foreground the app, the state should be properly restored. This is not being handled properly for the Plaid SDK.
Actual:
You can observe this use case in the video I have attached. If you would like to test, turn on DO NOT KEEP ACTIVITIES in developer options
Expected:
When a user background our app and is in Plaid and the OS kills the activity, upon recreation, plaid should resume its previous state.
Environment
Steps to Reproduce
If necessary, describe the problem you have been experiencing in more detail.
Please include the configuration you are using for Link (exluding your keys
and personally identifiable information)
Link Android SDK 3.2.6
I'm launching your SDK like so:
Plaid.create(requireActivity().application, link).open(requireActivity())
Expected Result
Plaid should restore the users state and returning them to where they were.
Video
plaidIssue.mp4
Logs
Any relevant logs from Android Logcat or the iOS console including stacktraces.
Code To Reproduce Issue
Use your sample app, I bet it reproduces there too.
The text was updated successfully, but these errors were encountered: