You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a part of ensuring that rewrite-clj continues to work with libraries that depend on it, I run their test suites against rewrite-clj master.
Zprint uses planck in its cljs test suite.
Its tests depended on a buggy behavior in planck v2.25.0 (TL;DR effectively this got fixed in v2.26.0: CLSJ-3324). Full deets here.
Zprint corrected its tests to work with planck v2.26.0.
But my canary tests run on GitHub Actions on ubuntu, within which my workflow installs v2.25.0 as the latest version of planck.
And the zprint tests now fail on v2.25.0. 🙂
So...
If it is not a big chore, I'd love to see planck v2.26.0 binaries for ubuntu.
@lread Yes #1087 is a concern. But, I also wonder if the older released binaries also have this problem. (In other words, even though there is a problem, it might not be caused by the 2.26.0 code). But, to be honest, I'd like to solve that one before making further releases.
Problem
I'd like to use planck v2.26.0 on GitHub Actions on ubuntu.
When I install planck on ubuntu following the README instructions, I see:
Full steps taken on macOS
And then:
Why is this a problem again?
As a part of ensuring that rewrite-clj continues to work with libraries that depend on it, I run their test suites against rewrite-clj master.
Zprint uses planck in its cljs test suite.
Its tests depended on a buggy behavior in planck v2.25.0 (TL;DR effectively this got fixed in v2.26.0: CLSJ-3324). Full deets here.
Zprint corrected its tests to work with planck v2.26.0.
But my canary tests run on GitHub Actions on ubuntu, within which my workflow installs v2.25.0 as the latest version of planck.
And the zprint tests now fail on v2.25.0. 🙂
So...
If it is not a big chore, I'd love to see planck v2.26.0 binaries for ubuntu.
I do see #1087.. maybe that is a blocker?
Am willing to help in any way I can.
The text was updated successfully, but these errors were encountered: