Add magic comment for freezing string literals (Studiosity#15)

Author: abrom

CHANGELOG.md

@@ -1,7 +1,8 @@
 # Changelog
 
 ## Unreleased
-- None
+### Fixed
+- Add magic comment for freezing string literals
 
 ## [0.7.1](releases/tag/v0.7.1) - 2019-01-22
 ### Added

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in grover.gemspec

Rakefile

@@ -1,4 +1,5 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
 
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'

bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'grover'

grover.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 

lib/grover.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'grover/version'
 
 require 'grover/utils'
@@ -92,7 +94,7 @@ def self.launch_params
   end
   private_constant :Processor
 
-  DEFAULT_HEADER_TEMPLATE = "<div class='date text left'></div><div class='title text center'></div>".freeze
+  DEFAULT_HEADER_TEMPLATE = "<div class='date text left'></div><div class='title text center'></div>"
   DEFAULT_FOOTER_TEMPLATE = Utils.strip_heredoc(<<-HTML).freeze
     <div class='url text left grow'></div>
     <div class='text right'><span class='pageNumber'></span>/<span class='totalPages'></span></div>

lib/grover/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Grover
   #
   # Configuration of the options for Grover HTML to PDF conversion

lib/grover/html_preprocessor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Grover
   #
   # Helper module for preparing HTML for conversion

lib/grover/middleware.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'combine_pdf'
 
 class Grover

lib/grover/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Grover
   #
   # Utility class for Grover helper methods
@@ -27,7 +29,7 @@ def self.squish(string)
     # @see active_support/core_ext/string/strip.rb
     #
     def self.strip_heredoc(string, inline: false)
-      string = string.gsub(/^#{string.scan(/^[ \t]*(?=\S)/).min}/, ''.freeze)
+      string = string.gsub(/^#{string.scan(/^[ \t]*(?=\S)/).min}/, '')
       inline ? string.delete("\n") : string
     end
 

lib/grover/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Grover
-  VERSION = '0.7.2'.freeze
+  VERSION = '0.7.2'
 end

spec/grover/configuration_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Grover::Configuration do

spec/grover/html_preprocessor_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Grover::HTMLPreprocessor do

spec/grover/middleware_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Grover::Middleware do

spec/grover/utils_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Grover::Utils do

spec/grover_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Grover do

spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start