Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] APNS tokens are stored for all past pubkeys of the app #70

Open
dcadenas opened this issue Sep 27, 2024 · 0 comments
Open

[Bug] APNS tokens are stored for all past pubkeys of the app #70

dcadenas opened this issue Sep 27, 2024 · 0 comments

Comments

@dcadenas
Copy link
Contributor

dcadenas commented Sep 27, 2024

We need to allow Nos to delete push notification registrations from our notification service to fix planetary-social/nos#1613

The APNS token identifies the app and the device. Each time we logout and use the app with different pubkeys they are all registered as using the same APNS token. This means that the current pubkey logged in to the app will receive notifications for all the previous users that used the app.

Implementation

Probably we should reuse the existing registration event and add a new property to the JSON to specify whether we are registering a pubkey or deregistering it. And when we receive a registration event with a apnsToken that matches an existing pubkey->apnsToken pair in our database then we delete the old pair and replace it with the new one.

Consider bundling this work with planetary-social/nos#852.

The deployment of this will need to be coordinated with planetary-social/nos#1613.

@dcadenas dcadenas moved this to Backlog in Nos Product Board Sep 27, 2024
@setch-l setch-l changed the title APNS tokens are stored for all past pubkeys of the app [Bug] APNS tokens are stored for all past pubkeys of the app Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant