From f6959ffe2c5defede07b61197078876c55370066 Mon Sep 17 00:00:00 2001 From: Itunu Raimi Date: Tue, 22 Oct 2024 15:15:11 +0100 Subject: [PATCH 1/2] temporary workaround for crash --- Nos/Router.swift | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Nos/Router.swift b/Nos/Router.swift index 651f3da8c..c9761e8ab 100644 --- a/Nos/Router.swift +++ b/Nos/Router.swift @@ -64,7 +64,14 @@ import Dependencies ) ) } else { - fatalError("Tried to push a note with no identifier; that's not going to work.") + let debuggingDetails = """ + noteId: \(String(describing: note.identifier)) \n + replaceableIdentifier: \(String(describing: note.replaceableIdentifier)) \n + noteAuthor: \(String(describing: note.author)) + """ + + crashReporting.report("Tried to push a note and it failed. Details: \n \(debuggingDetails)") + assertionFailure("Tried to push a note and it failed. Details: \n \(debuggingDetails)") } } From f46d7226e22bf75e6c6c36a2d6d027a9f3d33466 Mon Sep 17 00:00:00 2001 From: Itunu Raimi Date: Tue, 22 Oct 2024 15:16:57 +0100 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cb5d60e1c..1b4604056 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Added the Account Success onboarding screen. Currently behind the “New Onboarding Flow” feature flag. [#1599](https://github.com/planetary-social/nos/issues/1599) - Updated the Age Verification onboarding screen. Currently behind the “New Onboarding Flow” feature flag. [#1651](https://github.com/planetary-social/nos/issues/1651) - Track opening mentions with Posthog. [#1480](https://github.com/planetary-social/nos/issues/1480) +- Avoid crash and print extra debugging details when a reposted note that has not finished loading is clicked. [#1669](https://github.com/planetary-social/nos/issues/1669) ## [0.2.2] - 2024-10-11Z