Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish implementing the time-to-CCF-SNR feature #21

Open
danechever opened this issue Apr 27, 2021 · 1 comment
Open

Finish implementing the time-to-CCF-SNR feature #21

danechever opened this issue Apr 27, 2021 · 1 comment

Comments

@danechever
Copy link
Collaborator

I've added a version of Dimitri's code which inverts the CCF SNR equation to get the exposure time required to get a specific SNR goal. However, Dimitri's version of the code assumes that he can compute the FPS based on the detector linearity and well depth. The current version of PSISIM has a user-provided n_exposures such that we can't dynamically compute the FPS for this function. Dimitri's version of this code also neglects the systematics so it only holds when we are not systematics limited. If possible, it'd be good to find a more general solution.

For now, the version of this function that I've implemented works well in the photon-noise-limited regime.

warnings.warn('This function is incomplete at the moment. Double check all results for accuracy.')

This raises a separate question: do we want to dynamically set the n_exposures as Dimitri does in his code or do we want to keep this as a user-provided value? As it is now, the user could set an exposure time, n_exoposures combination that would saturate the detector.

@danechever
Copy link
Collaborator Author

Related to #32 which will allow us to dynamically set the exposure time and frames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant