Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile wallet.internal and wallet.loader.LoadedWallet() #75

Open
itswisdomagain opened this issue Nov 23, 2019 · 0 comments
Open

Reconcile wallet.internal and wallet.loader.LoadedWallet() #75

itswisdomagain opened this issue Nov 23, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@itswisdomagain
Copy link
Contributor

Follow up to #57.

The wallet is considered to be open if wallet.internal != nil. wallet.internal is assigned whenever a wallet is created or opened using wallet.loader, which also sets the created/opened wallet to wallet.loader.LoadedWallet().

If there are scenarios where the wallet is unloaded but wallet.internal is not unset, the impression would be that there is an opened/loaded wallet, when there really isn't.

Even if such scenarios do not come up, it's quite redundant to store the same variable in 2 places when 1 will suffice.

Proposal is to remove the wallet.internal property and introduce a wallet.internal() alias method that return wallet.loader.LoadedWallet().

@oluwandabira oluwandabira added the enhancement New feature or request label Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants