Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table.md icons broken due to extra "dist" in path #43

Closed
smadep opened this issue Sep 16, 2022 · 3 comments
Closed

table.md icons broken due to extra "dist" in path #43

smadep opened this issue Sep 16, 2022 · 3 comments
Assignees
Milestone

Comments

@smadep
Copy link

smadep commented Sep 16, 2022

sbTable.Append($"![{entityName}](dist/{category}/{entityName}.png?raw=true) | ");

and second occurance below.

@Potherca Potherca self-assigned this Nov 18, 2022
@Potherca
Copy link
Member

Thank you for reporting this! Somehow I completely missed the GitHub notification for this issue 😞

@travisnielsen
Copy link
Contributor

table.md is written to the dist folder as part of sprite generation process. The contents of that file are used to replace the table in AzureSymbols.md which is a directory level higher. Therefore, dist is required in the path and you can see icons load correctly on the Azure symbols page.

I don't believe we have this documented and I can add it to Release v2.2.

@Potherca Potherca added this to the v2.2.0 milestone Dec 21, 2022
@Potherca
Copy link
Member

Potherca commented Jan 2, 2023

Resolved by #44

@Potherca Potherca closed this as completed Jan 2, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in All Projects Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants