From b7f25f064eb03ae26b30f3d01ebf485ee6156841 Mon Sep 17 00:00:00 2001 From: Ryo Aoyama Date: Thu, 25 Jan 2024 15:43:42 +0900 Subject: [PATCH] Drop support for Carthage (#56) --- .github/ISSUE_TEMPLATE/QUESTION.md | 2 - .gitignore | 7 --- .swift-version | 1 - Makefile | 1 - README.md | 14 +----- XCConfigs/playbook-snapshot.xcconfig | 6 --- XCConfigs/playbook-ui.xcconfig | 4 -- XCConfigs/playbook.xcconfig | 5 -- XCConfigs/project.xcconfig | 20 -------- project.yml | 74 ---------------------------- 10 files changed, 1 insertion(+), 133 deletions(-) delete mode 100644 .swift-version delete mode 100644 XCConfigs/playbook-snapshot.xcconfig delete mode 100644 XCConfigs/playbook-ui.xcconfig delete mode 100644 XCConfigs/playbook.xcconfig delete mode 100644 XCConfigs/project.xcconfig delete mode 100644 project.yml diff --git a/.github/ISSUE_TEMPLATE/QUESTION.md b/.github/ISSUE_TEMPLATE/QUESTION.md index bcf708e..f1b4ef1 100644 --- a/.github/ISSUE_TEMPLATE/QUESTION.md +++ b/.github/ISSUE_TEMPLATE/QUESTION.md @@ -25,5 +25,3 @@ about: Create a bug question. - Xcode version: - Devices/Simulators: - -- Carthage version: diff --git a/.gitignore b/.gitignore index c9dcd2c..b915de5 100644 --- a/.gitignore +++ b/.gitignore @@ -20,16 +20,9 @@ build/ archive/ *.xcframework -## Gem -.bundle -vendor - ## npm node_modules -## Carthage -Carthage/Build - ## SwiftPM .swiftpm .build diff --git a/.swift-version b/.swift-version deleted file mode 100644 index a75b92f..0000000 --- a/.swift-version +++ /dev/null @@ -1 +0,0 @@ -5.1 diff --git a/Makefile b/Makefile index 9518cf7..dc4f7a6 100644 --- a/Makefile +++ b/Makefile @@ -8,7 +8,6 @@ all: proj format .PHONY: proj proj: - $(SWIFT_RUN) --package-path Tools xcodegen $(SWIFT_RUN) --package-path Tools xcodegen --spec Example/project.yml --project Example .PHONY: format diff --git a/README.md b/README.md index 087afbe..6eed5ed 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,6 @@
Release Swift Package Manager -Carthage `Playbook` is a library that provides a sandbox for building UI components without having to worry about application-specific dependencies, strongly inspired by [Storybook](https://storybook.js.org/) for JavaScript in web-frontend development. @@ -182,10 +181,7 @@ The generated snapshot images can be used for more advanced visual regression te - Swift 5.1+ - Xcode 11.0+ -- iOS - - `Playbook`: 11.0+ - - `PlaybookSnapshot`: 11.0+ - - `PlaybookUI`: 13.0+ +- iOS 13.0+ --- @@ -197,14 +193,6 @@ Playbook features are separated into the following frameworks. - `PlaybookSnapshot`: Generates snapshots of all components. - `PlaybookUI`: Products a browsing UI for components managed by Playbook. -### [Carthage](https://github.com/Carthage/Carthage) - -Add the following to your `Cartfile`: - -``` -github "playbook-ui/playbook-ios" -``` - ### [Swift Package Manager](https://developer.apple.com/documentation/xcode/adding_package_dependencies_to_your_app) Select Xcode menu `File > Swift Packages > Add Package Dependency...` and enter repository URL with GUI. diff --git a/XCConfigs/playbook-snapshot.xcconfig b/XCConfigs/playbook-snapshot.xcconfig deleted file mode 100644 index 1e0d19d..0000000 --- a/XCConfigs/playbook-snapshot.xcconfig +++ /dev/null @@ -1,6 +0,0 @@ -#include "./project.xcconfig" - -IPHONEOS_DEPLOYMENT_TARGET = 11.0 -FRAMEWORK_SEARCH_PATHS = $(inherited) $(PLATFORM_DIR)/Developer/Library/Frameworks -APPLICATION_EXTENSION_API_ONLY = YES -ENABLE_BITCODE = NO diff --git a/XCConfigs/playbook-ui.xcconfig b/XCConfigs/playbook-ui.xcconfig deleted file mode 100644 index 1b2f9f5..0000000 --- a/XCConfigs/playbook-ui.xcconfig +++ /dev/null @@ -1,4 +0,0 @@ -#include "./project.xcconfig" - -IPHONEOS_DEPLOYMENT_TARGET = 13.0 -APPLICATION_EXTENSION_API_ONLY = YES diff --git a/XCConfigs/playbook.xcconfig b/XCConfigs/playbook.xcconfig deleted file mode 100644 index 09747ea..0000000 --- a/XCConfigs/playbook.xcconfig +++ /dev/null @@ -1,5 +0,0 @@ -#include "./project.xcconfig" - -IPHONEOS_DEPLOYMENT_TARGET = 11.0 -OTHER_LDFLAGS = -weak_framework SwiftUI -weak_framework Combine -APPLICATION_EXTENSION_API_ONLY = YES diff --git a/XCConfigs/project.xcconfig b/XCConfigs/project.xcconfig deleted file mode 100644 index 2eb3f69..0000000 --- a/XCConfigs/project.xcconfig +++ /dev/null @@ -1,20 +0,0 @@ -SDKROOT = -SUPPORTED_PLATFORMS = iphoneos iphonesimulator -TARGETED_DEVICE_FAMILY = 1,2 -VALID_ARCHS[sdk=iphoneos*] = arm64 armv7 armv7s -VALID_ARCHS[sdk=iphonesimulator*] = arm64 i386 x86_64 - -BUILD_LIBRARY_FOR_DISTRIBUTION = YES -CODE_SIGNING_REQUIRED = NO -CODE_SIGN_IDENTITY = -CODE_SIGN_STYLE = Manual -SKIP_INSTALL = NO -OTHER_LDFLAGS = $(inherited) -INSTALL_PATH = $(LOCAL_LIBRARY_DIR)/Frameworks -DYLIB_COMPATIBILITY_VERSION = 1 -DYLIB_CURRENT_VERSION = 1 -DYLIB_INSTALL_NAME_BASE = @rpath -LD_RUNPATH_SEARCH_PATHS = $(inherited) @executable_path/../Frameworks @loader_path/Frameworks @loader_path/../Frameworks -DEFINES_MODULE = NO -GCC_OPTIMIZATION_LEVEL = s -SWIFT_OPTIMIZATION_LEVEL = -O diff --git a/project.yml b/project.yml deleted file mode 100644 index 4987169..0000000 --- a/project.yml +++ /dev/null @@ -1,74 +0,0 @@ -name: Playbook -configFiles: - Debug: XCConfigs/project.xcconfig - Release: XCConfigs/project.xcconfig -options: - bundleIdPrefix: app.playbook-ui - createIntermediateGroups: true - -schemes: - Playbook: - build: - targets: - Playbook: all - PlaybookUI: [test] - PlaybookSnapshot: [test] - test: - targets: - - Playbook-Tests - commandLineArguments: - -AppleLanguages (en): true - environmentVariables: - SNAPSHOT_DIR: $(SOURCE_ROOT)/Snapshots - - PlaybookUI: - build: - targets: - PlaybookUI: all - - PlaybookSnapshot: - build: - targets: - PlaybookSnapshot: all - -targets: - Playbook: - type: framework - platform: iOS - sources: - - Sources/Playbook - configFiles: - Debug: XCConfigs/playbook.xcconfig - Release: XCConfigs/playbook.xcconfig - - PlaybookUI: - type: framework - platform: iOS - sources: - - Sources/PlaybookUI - configFiles: - Debug: XCConfigs/playbook-ui.xcconfig - Release: XCConfigs/playbook-ui.xcconfig - dependencies: - - target: Playbook - - PlaybookSnapshot: - type: framework - platform: iOS - sources: - - Sources/PlaybookSnapshot - configFiles: - Debug: XCConfigs/playbook-snapshot.xcconfig - Release: XCConfigs/playbook-snapshot.xcconfig - dependencies: - - target: Playbook - - Playbook-Tests: - type: bundle.unit-test - platform: iOS - sources: - - Tests - dependencies: - - target: Playbook - - target: PlaybookUI - - target: PlaybookSnapshot