Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use fullScreenCover rather than sheet for GalleryContent on iPad #73

Open
2 tasks done
Pikuseru opened this issue Sep 26, 2024 · 0 comments
Open
2 tasks done

Comments

@Pikuseru
Copy link

Pikuseru commented Sep 26, 2024

Checklist

  • Reviewed the README and documents.
  • Searched existing issues for ensure not duplicated.

Description

It'd be really nice to be able to view components using full screen cover on an iPad.

Motivation and Context

We're using Playbook to preview multiple components at a time (we're constructing pages made out of components), and sometimes our components are quite large and fill the whole screen. Apple's sheet presentation gives us quite a small preview area.

Proposed Solution

Giving us some way to configure the presentation, either as sheet or fullScreenCover, or replacing the modifier.

https://github.com/playbook-ui/playbook-ios/blob/master/Sources/PlaybookUI/Internal/Views/PlaybookGalleryContent.swift#L66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant