Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor spams websocket error messages #1213

Open
LeXXik opened this issue Oct 23, 2024 · 3 comments
Open

Editor spams websocket error messages #1213

LeXXik opened this issue Oct 23, 2024 · 3 comments
Assignees

Comments

@LeXXik
Copy link

LeXXik commented Oct 23, 2024

If Editor is in the other tab for a while, the connection times out. Once it does, it spams the error messages:

image

@kpal81xd
Copy link

So unfortunately that code is from sharedb itself so hopefully I dont need to patch it 😅

@kpal81xd kpal81xd self-assigned this Nov 12, 2024
@LeXXik
Copy link
Author

LeXXik commented Nov 12, 2024

Right, that's just the sending method. Not sure what is calling it, but probably it shouldn't, if the socket state is not right.

@kpal81xd
Copy link

Yea its to do with a custom override in the socket on close handler that tries to clean up document state before calling the original on close event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants