You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we have GraphNode.find, GraphNode.findOne and GraphNode.forEach to traverse a specific node (included) and all its descendants. The first two are also used in Entity.findComponent and Entity.findComponents (and possibly Entity.findScript and Entity.findScripts if #5851 is accepted and merged).
The main idea is to add the same functions for ancestors but in the original PR, we were debating about whether these functions should include the current node or not. This led to also add function for descendants only (thus excluding current node), the same way GraphNode.findByTag and GraphNode.findByPath currently work.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Follow-up of #4603
Currently we have
GraphNode.find
,GraphNode.findOne
andGraphNode.forEach
to traverse a specific node (included) and all its descendants. The first two are also used inEntity.findComponent
andEntity.findComponents
(and possiblyEntity.findScript
andEntity.findScripts
if #5851 is accepted and merged).The main idea is to add the same functions for ancestors but in the original PR, we were debating about whether these functions should include the current node or not. This led to also add function for descendants only (thus excluding current node), the same way
GraphNode.findByTag
andGraphNode.findByPath
currently work.Beta Was this translation helpful? Give feedback.
All reactions