Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor existing DSL docs. #288

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Refactor existing DSL docs. #288

merged 5 commits into from
Feb 10, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Jan 31, 2024

Expand existing DSL docs

Change Type

  • patch
  • minor
  • major

Release Notes

Update DSL docs

Version

Published prerelease version: 0.7.0-next.1

Changelog

Release Notes

Refactor existing DSL docs. (#288)

Update DSL docs

Remove Applitools (#277)

Enhance AsyncViewStub.awaitView() to ensure any child AsyncViewStubs are resolved as well. This really only affects initial hydration, preventing weird isolated rendering jank by ensuring everything is ready to be shown on screen before actually rendering the top-level asset.


🚀 Enhancement

🐛 Bug Fix

📝 Documentation

Authors: 13

@KetanReddy KetanReddy added documentation Changes only affect the documentation patch Increment the patch version when merged labels Jan 31, 2024
@KetanReddy KetanReddy self-assigned this Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c26e7b) 81.87% compared to head (b9d3a71) 81.88%.
Report is 33 commits behind head on main.

❗ Current head b9d3a71 differs from pull request most recent head 935fe28. Consider uploading reports for the commit 935fe28 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   81.87%   81.88%           
=======================================
  Files         134      134           
  Lines        4608     4609    +1     
  Branches     1138     1138           
=======================================
+ Hits         3773     3774    +1     
  Misses        552      552           
  Partials      283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/site/pages/assets/dsl.mdx Outdated Show resolved Hide resolved
docs/site/pages/assets/dsl.mdx Outdated Show resolved Hide resolved
docs/site/pages/content/assets-views.mdx Outdated Show resolved Hide resolved
docs/site/pages/content/assets-views.mdx Outdated Show resolved Hide resolved
docs/site/pages/content/assets-views.mdx Outdated Show resolved Hide resolved
docs/site/pages/dsl/index.mdx Outdated Show resolved Hide resolved
docs/site/pages/dsl/index.mdx Outdated Show resolved Hide resolved
options: [true, false],
},
],
} satisfies Schema.DataType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOOO nice satisfies

docs/site/pages/dsl/views.mdx Outdated Show resolved Hide resolved
docs/site/pages/dsl/views.mdx Show resolved Hide resolved
docs/site/pages/assets/dsl.mdx Show resolved Hide resolved
docs/site/pages/assets/dsl.mdx Show resolved Hide resolved
docs/site/pages/assets/dsl.mdx Outdated Show resolved Hide resolved
docs/site/pages/assets/dsl.mdx Outdated Show resolved Hide resolved
docs/site/pages/content/assets-views.mdx Outdated Show resolved Hide resolved
@KetanReddy KetanReddy marked this pull request as ready for review February 2, 2024 20:45
@KetanReddy KetanReddy changed the title [WIP] Refactor existing DSL docs. Refactor existing DSL docs. Feb 2, 2024
@KetanReddy KetanReddy merged commit 4b551b3 into main Feb 10, 2024
9 checks passed
@KetanReddy KetanReddy deleted the docs/dsl-docs branch February 10, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants