Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/more validation fixes #65

Merged
merged 13 commits into from
Feb 14, 2024
Merged

Fix/more validation fixes #65

merged 13 commits into from
Feb 14, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Feb 6, 2024

Change Type (required)

  • patch
  • minor
  • major

Release Notes

  • XLR: Fix Exclude on Union Types
  • XLR: Fix shallow clones causing unintended aftereffects
  • XLR SDK: Fix application of base Player Transforms to XLRs when loaded
  • CLI: New Plugins to add Plugins to LSP and XLR SDK Transforms

Version

Published prerelease version: 0.4.2-next.1

Changelog

Release Notes

Fix/more validation fixes (#65)

  • XLR: Fix Exclude on Union Types
  • XLR: Fix shallow clones causing unintended aftereffects
  • XLR SDK: Fix application of base Player Transforms to XLRs when loaded
  • CLI: New Plugins to add Plugins to LSP and XLR SDK Transforms

Validation Improvements (#63)

Properly parse Excludes keyword when compiling XLRs


🐛 Bug Fix

Authors: 1

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Feb 6, 2024
@KetanReddy KetanReddy self-assigned this Feb 6, 2024
@KetanReddy
Copy link
Member Author

/canary

@KetanReddy
Copy link
Member Author

/canary

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (e6bc0ce) 55.40% compared to head (b74f6c8) 54.91%.

Files Patch % Lines
xlr/utils/src/validation-helpers.ts 18.18% 5 Missing and 4 partials ⚠️
xlr/sdk/src/sdk.ts 50.00% 3 Missing and 3 partials ⚠️
xlr/sdk/src/validator.ts 0.00% 6 Missing ⚠️
xlr/sdk/src/utils.ts 54.54% 1 Missing and 4 partials ⚠️
language/json-language-service/src/index.ts 0.00% 3 Missing ⚠️
...nguage/json-language-service/src/xlr/transforms.ts 86.36% 0 Missing and 3 partials ⚠️
cli/src/plugins/LSPPluginPlugin.ts 0.00% 2 Missing ⚠️
cli/src/plugins/LSPTransformsPlugin.ts 0.00% 2 Missing ⚠️
xlr/sdk/src/registry/basic-registry.ts 0.00% 0 Missing and 1 partial ⚠️
xlr/utils/src/ts-helpers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   55.40%   54.91%   -0.49%     
==========================================
  Files          66       68       +2     
  Lines        3305     3338      +33     
  Branches      991     1001      +10     
==========================================
+ Hits         1831     1833       +2     
- Misses       1128     1144      +16     
- Partials      346      361      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy marked this pull request as ready for review February 12, 2024 23:57
xlr/sdk/src/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@rafbcampos rafbcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KetanReddy KetanReddy force-pushed the fix/more-validation-fixes branch from 5f58103 to b74f6c8 Compare February 14, 2024 17:36
@KetanReddy KetanReddy merged commit cbbead8 into main Feb 14, 2024
7 of 9 checks passed
@KetanReddy KetanReddy deleted the fix/more-validation-fixes branch February 14, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants