Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Import Errors When Using DSL in ESM First Projects #87

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Mar 26, 2024

When importing @player-tools/dsl and running tests on components, there would be issues with mergeRefs not being found. Most likely this was caused by using a non-ESM version of the dependent library. This PR bumps the version to a package that ships an ESM version of the functionality.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Release Notes

Fix issue with DSL package in ESM projects

📦 Published PR as canary version: 0.5.2--canary.87.2261

Try this version out locally by upgrading relevant packages to 0.5.2--canary.87.2261

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Mar 26, 2024
@KetanReddy KetanReddy self-assigned this Mar 26, 2024
@KetanReddy KetanReddy requested a review from adierkens as a code owner March 26, 2024 20:05
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.36%. Comparing base (feae742) to head (4612de6).

Files Patch % Lines
language/dsl/src/utils.tsx 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   77.34%   77.36%   +0.01%     
==========================================
  Files          62       62              
  Lines       10425    10443      +18     
  Branches     1084     1089       +5     
==========================================
+ Hits         8063     8079      +16     
- Misses       2343     2345       +2     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy
Copy link
Member Author

/canary

@KetanReddy KetanReddy force-pushed the bugfix/esm-components branch from 7740075 to 4612de6 Compare March 27, 2024 03:10
@KetanReddy
Copy link
Member Author

/canary

@KetanReddy KetanReddy merged commit 4cc51ce into main Mar 27, 2024
9 checks passed
@KetanReddy KetanReddy deleted the bugfix/esm-components branch March 27, 2024 18:47
@intuit-svc intuit-svc mentioned this pull request Mar 27, 2024
3 tasks
@intuit-svc intuit-svc mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants