Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 support #41

Closed
brkaisin opened this issue Oct 18, 2023 · 7 comments
Closed

Scala 3 support #41

brkaisin opened this issue Oct 18, 2023 · 7 comments

Comments

@brkaisin
Copy link

brkaisin commented Oct 18, 2023

Since Play >=2.9 supports Scala 3, implement a version of the library in Scala 3. This issue is blocked by this one (with opened PR #40).

I see that there is already WIP on this task: see PR #36.

How can I help ?

@MathisGuillet1
Copy link
Contributor

Hello @brkaisin
Now that the transfer is done, I will try to provide Scala 3 in the following weeks along with Play 2.9 support.

@dejvid
Copy link

dejvid commented Nov 7, 2023

Thank you so much! I appreciate it. We are waiting for this library to be upgraded. I thought it was archived, but I see it moved here. I feel very happy about it. I though I would need to do change the silhouette library altogether.

@ndeverge
Copy link
Member

@mkurz
I tested both #36 and #39 on my Play project (migrated to Play 2.9), and both PRs work successfully.
What should we do? I'd suggest to merge #39 and close #36?

@mkurz
Copy link
Member

mkurz commented Nov 21, 2023

@ndeverge Did you add cross compile to Scala 3.3.1?

@ndeverge
Copy link
Member

@ndeverge Did you add cross compile to Scala 3.3.1?

not yet, let me try that

@MathisGuillet1
Copy link
Contributor

Ok, we now have something passing cross compile 🚀
@ndeverge Feel free to test it with your scala 3 application.
Now I hope @mkurz can help to set up github actions and publish it (both with play 2.9 and 3.0 pekko).

I am really waiting for this library to upgrade to play 3.0 and pekko (and maybe not the only one).

@mkurz
Copy link
Member

mkurz commented Dec 9, 2023

Closing now that version 9.0.0 with support for Play 2.9 and Scala 3 is released now: https://github.com/playframework/play-silhouette/releases/tag/9.0.0
@ndeverge and/or @MathisGuillet1 will release version 10 for Play 3 support 😉

@mkurz mkurz closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants