Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nullable getters use Optional<T> or Option[T] #132

Open
wsargent opened this issue Jun 13, 2017 · 3 comments
Open

Make nullable getters use Optional<T> or Option[T] #132

wsargent opened this issue Jun 13, 2017 · 3 comments

Comments

@wsargent
Copy link
Member

In many places, the Java WSRequest and WSResponse still use methods which return null:

public interface StandaloneWSRequest {
    String getUsername();

    String getPassword();

    WSAuthScheme getScheme();

    WSSignatureCalculator getCalculator();

    Duration getRequestTimeoutDuration();

    boolean getFollowRedirects();

    String getContentType();
}

And they should return Optional<String> etc where appropriate.

@wsargent
Copy link
Member Author

Addressed by #129

@wsargent wsargent modified the milestone: 2.0 Jun 13, 2017
@dmitraver
Copy link
Contributor

hi, is this one up for picking or is it already fixed by #129 ?

@marcospereira
Copy link
Member

Hey, @dmitraver,

it was already addressed by #129.

Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants