Skip to content

feat: Add WithDeps option to install system dependencies #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

feat: Add WithDeps option to install system dependencies #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ func (d *PlaywrightDriver) installBrowsers() error {
additionalArgs = append(additionalArgs, "--dry-run")
}

if d.options.WithDeps {
additionalArgs = append(additionalArgs, "--with-deps")
}

cmd := d.Command(additionalArgs...)
cmd.Stdout = d.options.Stdout
cmd.Stderr = d.options.Stderr
Expand Down Expand Up @@ -243,6 +247,8 @@ type RunOptions struct {
SkipInstallBrowsers bool
// if not set and SkipInstallBrowsers is false, will download all browsers (chromium, firefox, webkit)
Browsers []string
// install system dependencies for browsers
WithDeps bool
Verbose bool // default true
Stdout io.Writer
Stderr io.Writer
Expand Down
Loading