From 51b7a03a210f288d5ee0d93ecbcab1eac3327c44 Mon Sep 17 00:00:00 2001
From: Marshall Asch <marshall.asch@plexapp.com>
Date: Tue, 2 Jul 2024 13:08:42 -0400
Subject: [PATCH] chore: update health checks and mount the secret even if its
 not an external secret

---
 .github/workflows/build.yaml                         | 4 ++--
 Dockerfile                                           | 2 +-
 charts/music-notifications/templates/deployment.yaml | 2 --
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 019c233..bf32e99 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -24,8 +24,8 @@ jobs:
             type=raw,value=latest,enable={{is_default_branch}}
             type=ref,event=branch,suffix=-{{sha}}
             type=ref,event=pr
-            type=sha,prefix=
-            type=sha
+            type=sha,prefix=,enable={{is_default_branch}}
+            type=sha,enable={{is_default_branch}}
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
diff --git a/Dockerfile b/Dockerfile
index 2c98251..be2f86c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,6 +1,6 @@
 FROM node:20.13.0-alpine
 
-ARG PORT=3000
+ENV PORT=3000
 WORKDIR /app
 COPY . /app
 RUN yarn install
diff --git a/charts/music-notifications/templates/deployment.yaml b/charts/music-notifications/templates/deployment.yaml
index a1446fd..273d698 100644
--- a/charts/music-notifications/templates/deployment.yaml
+++ b/charts/music-notifications/templates/deployment.yaml
@@ -27,11 +27,9 @@ spec:
       - name: {{ .Chart.Name }}
         image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
         imagePullPolicy: {{ .Values.image.pullPolicy }}
-        {{- if .Values.secret.externalSecretKey  }}
         envFrom:
         - secretRef:
             name: {{ include "music-notifications.fullname" . }}
-        {{- end }}
         livenessProbe:
           failureThreshold: 1
           httpGet: