Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that template's markup is valid #153

Open
gforcada opened this issue Jun 28, 2023 · 1 comment
Open

Validate that template's markup is valid #153

gforcada opened this issue Jun 28, 2023 · 1 comment
Labels
04 type: enhancement making existing stuff better 13 prio: normal needs a fix, but not now 42 lvl: moderate fair project insight needed

Comments

@gforcada
Copy link
Member

There was a template with broken HTML, we should know that automatically, so we can fix that whenever that happens, i.e. a pre-commit hook 🎉

@petschki found out this: https://github.com/Lucas-C/pre-commit-hooks-lxml/tree/master/pre_commit_hooks we could create a pre-commit hook here in plone/meta or somewhere else in collective, the location is not that important, to validate that our template files are actually valid 💯

@petschki
Copy link
Member

found this one yesterday: https://github.com/Lucas-C/pre-commit-hooks-java/

though it says "needs java in $PATH" the id validate-html could be used 1:1 for that.

@gforcada gforcada added 04 type: enhancement making existing stuff better 13 prio: normal needs a fix, but not now 42 lvl: moderate fair project insight needed labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 type: enhancement making existing stuff better 13 prio: normal needs a fix, but not now 42 lvl: moderate fair project insight needed
Projects
None yet
Development

No branches or pull requests

2 participants