Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register_translation() - why required language? #330

Open
zopyx opened this issue Dec 5, 2018 · 0 comments
Open

register_translation() - why required language? #330

zopyx opened this issue Dec 5, 2018 · 0 comments

Comments

@zopyx
Copy link
Member

zopyx commented Dec 5, 2018

The signature of register_translation(language, obj) is a bit weird.

First the translated content object obj should have proper language property set. Having no language set is an indicator of bad or lack of metadata. register_translation() should take the language from obj.

What is the usecase for specifying a possibly different language here?

Regarding the documentation:

https://docs.plone.org/develop/plone/i18n/translating_content.html

mentions register_translation()

but the package's README does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants