Translation id chooser heuristics are not ok for some edge cases

[tiberiuichim]

plone.app.multilingual/src/plone/app/multilingual/factory.py

Lines 68 to 76 in 6325639

	def __call__(self, parent, language):
	content_id = self.context.getId()
	splitted = content_id.split("-")
	# ugly heuristic (searching for something like 'de', 'en' etc.)
	if len(splitted) > 1 and len(splitted[-1]) == 2:
	content_id = "-".join(splitted[:-1])
	while content_id in parent.objectIds():
	content_id = f"{content_id}-{language}"
	return content_id

It should regenerate a new id in the context of the new parent.

If I have an id like items-74, it tries to name the translation as items, which triggers:

  Module plone.app.multilingual.api, line 46, in translate
  Module plone.app.multilingual.manager, line 135, in add_translation
  Module plone.app.multilingual.factory, line 93, in __call__
  Module plone.dexterity.content, line 808, in invokeFactory
  Module Products.CMFCore.PortalFolder, line 299, in invokeFactory
  Module Products.CMFCore.TypesTool, line 809, in constructContent
  Module Products.CMFCore.TypesTool, line 308, in constructInstance
  Module Products.CMFCore.TypesTool, line 570, in _constructInstance
  Module Products.BTreeFolder2.BTreeFolder2, line 436, in _setObject
  Module plone.folder.ordered, line 253, in _checkId
  Module Products.CMFCore.PortalFolder, line 318, in _checkId
  Module OFS.ObjectManager, line 125, in checkValidId
zExceptions.BadRequest: The id "items" is invalid - it is already in use

[lokeshmeesala]

Hey, I can work on this. In the given example, either content_id is not in parent.objectIds() or 'language' argument is empty. Please let me know how a new id must be generated in these cases. Thanks.