Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing comma lead to unexpected variable remove from url #472

Open
yurj opened this issue Nov 4, 2024 · 0 comments
Open

missing comma lead to unexpected variable remove from url #472

yurj opened this issue Nov 4, 2024 · 0 comments

Comments

@yurj
Copy link
Contributor

yurj commented Nov 4, 2024

return addQuery(self.request, url, exclude=("post_path"))

there's a missing comma, this is not a tuple while addQuery expect a tuple:

def addQuery(request, url, exclude=tuple(), **extras):

so if you've a variable 'a' the 'a' not in 'post_path' is false and thus it is not included.

yurj added a commit that referenced this issue Nov 4, 2024
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Nov 4, 2024
Branch: refs/heads/master
Date: 2024-11-04T16:25:22+01:00
Author: Yuri (yurj) <[email protected]>
Commit: plone/plone.app.multilingual@0674f94

Update helper_views.py

See plone/plone.app.multilingual#472

Files changed:
M src/plone/app/multilingual/browser/helper_views.py
Repository: plone.app.multilingual

Branch: refs/heads/master
Date: 2024-11-04T16:27:06+01:00
Author: Yuri (yurj) <[email protected]>
Commit: plone/plone.app.multilingual@c596751

Create 472.bug

Files changed:
A news/472.bug
Repository: plone.app.multilingual

Branch: refs/heads/master
Date: 2024-11-04T17:15:19+01:00
Author: Mikel Larreategi (erral) <[email protected]>
Commit: plone/plone.app.multilingual@315b308

Merge pull request #473 from plone/yurj-patch-472-missing-comma

Update helper_views.py

Files changed:
A news/472.bug
M src/plone/app/multilingual/browser/helper_views.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant