From 70a42d5719214a939c17b5267d58cfdb587573a3 Mon Sep 17 00:00:00 2001 From: Mauro Amico Date: Thu, 17 Aug 2023 09:10:50 +0200 Subject: [PATCH 1/5] change interface declaration type #186 --- plone/dexterity/content.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plone/dexterity/content.py b/plone/dexterity/content.py index 18e0faa..bf7c15d 100644 --- a/plone/dexterity/content.py +++ b/plone/dexterity/content.py @@ -42,7 +42,7 @@ from zope.interface import implementer from zope.interface.declarations import getObjectSpecification from zope.interface.declarations import implementedBy -from zope.interface.declarations import Implements +from zope.interface.declarations import Provides from zope.interface.declarations import ObjectSpecificationDescriptor from zope.interface.interface import Method from zope.schema.interfaces import IContextAwareDefaultFactory @@ -193,7 +193,7 @@ def __get__(self, inst, cls=None): return spec dynamically_provided.append(spec) - all_spec = Implements(*dynamically_provided) + all_spec = Provides(*dynamically_provided) inst._v__providedBy__ = updated + (all_spec,) return all_spec From 8dabb6fd727bdab0e4f49f953050eeb17eaa2520 Mon Sep 17 00:00:00 2001 From: Mauro Amico Date: Thu, 17 Aug 2023 09:22:25 +0200 Subject: [PATCH 2/5] isort --- plone/dexterity/content.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plone/dexterity/content.py b/plone/dexterity/content.py index bf7c15d..50e2d0b 100644 --- a/plone/dexterity/content.py +++ b/plone/dexterity/content.py @@ -42,8 +42,8 @@ from zope.interface import implementer from zope.interface.declarations import getObjectSpecification from zope.interface.declarations import implementedBy -from zope.interface.declarations import Provides from zope.interface.declarations import ObjectSpecificationDescriptor +from zope.interface.declarations import Provides from zope.interface.interface import Method from zope.schema.interfaces import IContextAwareDefaultFactory from zope.security.interfaces import IPermission From be930329e317923906bf44290558e3dc41af97b1 Mon Sep 17 00:00:00 2001 From: Mauro Amico Date: Sun, 20 Aug 2023 12:51:46 +0200 Subject: [PATCH 3/5] fix provides --- plone/dexterity/content.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plone/dexterity/content.py b/plone/dexterity/content.py index 50e2d0b..593b70c 100644 --- a/plone/dexterity/content.py +++ b/plone/dexterity/content.py @@ -193,7 +193,7 @@ def __get__(self, inst, cls=None): return spec dynamically_provided.append(spec) - all_spec = Provides(*dynamically_provided) + all_spec = Provides(cls, *dynamically_provided) inst._v__providedBy__ = updated + (all_spec,) return all_spec From 76884a3d87226176767451e871365ae929f0b15e Mon Sep 17 00:00:00 2001 From: Mauro Amico Date: Sun, 20 Aug 2023 16:50:03 +0200 Subject: [PATCH 4/5] changelog --- news/187.bug | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/187.bug diff --git a/news/187.bug b/news/187.bug new file mode 100644 index 0000000..6540e66 --- /dev/null +++ b/news/187.bug @@ -0,0 +1 @@ +Fix a memory leak as reported in https://github.com/plone/Products.CMFPlone/issues/3829, changing interface decleration type as suggested by @d-maurer in https://github.com/plone/plone.dexterity/issues/186 [mamico] From 5ba3f01a776744ffceb37be16982cd247b475228 Mon Sep 17 00:00:00 2001 From: Mauro Amico Date: Sun, 20 Aug 2023 16:54:22 +0200 Subject: [PATCH 5/5] typo --- news/187.bug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/news/187.bug b/news/187.bug index 6540e66..0fe8b1f 100644 --- a/news/187.bug +++ b/news/187.bug @@ -1 +1 @@ -Fix a memory leak as reported in https://github.com/plone/Products.CMFPlone/issues/3829, changing interface decleration type as suggested by @d-maurer in https://github.com/plone/plone.dexterity/issues/186 [mamico] +Fix a memory leak as reported in https://github.com/plone/Products.CMFPlone/issues/3829, changing interface declaration type as suggested by @d-maurer in https://github.com/plone/plone.dexterity/issues/186 [mamico]