Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v 2.1.9 causes issues in Plone 5.2.2 (resources not loaded after 5.2.1 upgrade) #224

Open
zopyx opened this issue Nov 4, 2020 · 4 comments

Comments

@zopyx
Copy link
Member

zopyx commented Nov 4, 2020

See https://community.plone.org/t/plone-resources-not-being-loaded-after-5-2-1-5-2-2-upgrade/13073/4

@zopyx zopyx changed the title v 2.1.6 causes issues in Plone 5.2.2 (resources not loaded after 5.2.1 upgrade) v 2.1.9 causes issues in Plone 5.2.2 (resources not loaded after 5.2.1 upgrade) Nov 4, 2020
@fredvd
Copy link
Member

fredvd commented Nov 19, 2020

@zopyx Did you have any success in further analysing/debugging this issue?

@zopyx
Copy link
Member Author

zopyx commented Nov 19, 2020

We looked into this hint but could not make much sense of it regarding our own theming

https://community.plone.org/t/plone-resources-not-being-loaded-after-5-2-1-5-2-2-upgrade/13073/5

@fredvd
Copy link
Member

fredvd commented Nov 19, 2020

In the screenshot I see the site is running in 'foreground' mode on the left (Plone 5.2.1) as it is loading the individual js bundles and not the 'production' metabundled js, as then you would only have default.js and logged-in.js, containing bundles like editor-tools etc.

It also seems as no requests are done at all, the provider in the main template trying to list the individual bundles fails
(

in the main template). But to troubleshoot it further it would be useful if we could check off any diazo related issues. If you run the site in development mode and add ?diazo.off=1 to the url, are the javascript resources available in the 'content' before Diazo is applied.

this is ultimately the view generating that list of js bundles:
https://github.com/plone/Products.CMFPlone/blob/2694f01b98638b5e07b25806c1fd5ed1ad72b67c/Products/CMFPlone/resources/browser/scripts.py

In your view it does manage to find add add part of the 'bootstrap' resources like jquery, but require.js should also be part of the output from the default_resources method. And the common.js is not part of the bootstrap/default plone js files, that might be part of the theme or custom modules in the site.

I can't directly find them, but I added a few more Exceptions to the resource 'finding' functions in the ++plone++ and ++resource++ namespaces last year. A single missing resource from an add'on bundle would crash the whole resource registry bundle and js list generation (and block you from entering the resource registry or configuration registry to fix it, :-( But if one resource cannot be found it should still log that now and skip to the next resources.

@fredvd
Copy link
Member

fredvd commented Nov 19, 2020

Found it, this part was merged: plone/Products.CMFPlone@733a99a

Hmm, and one of those try: except: 's wasnt' logging anything before, but I added another exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants