Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up training #871

Merged
merged 16 commits into from
Nov 18, 2024
Merged

Tidy up training #871

merged 16 commits into from
Nov 18, 2024

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Nov 18, 2024

This PR is a housecleaning chore. It resolves many errors and warnings, except for the following issues.

  • The lack of meta information in the abandoned trainings is annoying and obscures checking for new trainings.
  • The LESS, JSX, and SCSS lexers have issues, with LESS being the worst. Do we still use LESS in Volto or anywhere else? Let's burn it with 🔥!

I am also looking into how to suppress the foregoing errors and warnings, so authors don't get nagged by trainings that are not theirs.


📚 Documentation preview 📚: https://plone6--871.org.readthedocs.build/

Copy link
Member

@ksuess ksuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy would you fix the link to preview, thank you.

@stevepiercy
Copy link
Contributor Author

Project created on RTD. Pull request previews should build, starting with the next new PR. Invites to be maintainers sent to:

@polyester
@sneridagh
@pbauer
@ksuess

I'll create a new PR to test.

@stevepiercy stevepiercy merged commit bdcd5de into main Nov 18, 2024
3 checks passed
@stevepiercy stevepiercy deleted the tidy-up-training branch November 18, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants