Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of Node.js #875

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix spelling of Node.js #875

merged 1 commit into from
Nov 18, 2024

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Nov 18, 2024


📚 Documentation preview 📚: https://plonetraining--875.org.readthedocs.build/

@stevepiercy
Copy link
Contributor Author

stevepiercy commented Nov 18, 2024

Yup, that was it. The value of project-slug on main in

project-slug: "plonetraining"
is what matters.

@ksuess would you please double-check?

@stevepiercy
Copy link
Contributor Author

Rats. I forgot that we already have a project configured to use the legacy branch. I deleted that RTD project I just created, and I pushed commits to the legacy branch in hopes it triggers future PR builds.

@stevepiercy stevepiercy reopened this Nov 18, 2024
@stevepiercy
Copy link
Contributor Author

OK, one more cycle through, and it should work going forward. Basically we do not want main to be published or active, but we do want legacy as shown here:

https://plone-training.readthedocs.io/

PRs should now get built at https://plone-training--PR#.org.readthedocs.build/.

Merging to get this going, and to do one more final test.

@stevepiercy stevepiercy merged commit 4031b4d into main Nov 18, 2024
5 of 6 checks passed
@stevepiercy stevepiercy deleted the test-rtd-pr-build branch November 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant